Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build:readme script and toctoc dependency #1189

Merged
merged 1 commit into from
Feb 23, 2019
Merged

Remove build:readme script and toctoc dependency #1189

merged 1 commit into from
Feb 23, 2019

Conversation

pushred
Copy link
Contributor

@pushred pushred commented Feb 22, 2019

Reasons for making this change

This is a followup to f62cfc4 which broke the build:readme script by removing the Table of Contents section from the README. On subsequent commits this script would fail with:

> toctoc README.md -w

Couldn't find expected TOC pattern: /## Table of Contents([\s\S])+\n---/

This also broke scripts that call build:readme like publish-to-npm and preversion / npm version. The 1.2.1 release must have performed these steps manually.

I don't see any other references to the toctoc dependency so I've removed it.

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Followup to f62cfc4 which broke the build:readme script
@epicfaace
Copy link
Member

Thanks!

@epicfaace epicfaace merged commit a7be6ee into rjsf-team:master Feb 23, 2019
CodeGains pushed a commit to CodeGains/react-jsonschema-form that referenced this pull request Mar 5, 2019
Followup to f62cfc4 which broke the build:readme script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants